[legacy-framework] Fix blitz generate in javascript projects
#2859
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![kodiakhq[bot]](https://avatars.githubusercontent.com/in/29196?s=60&v=4){kind=small}
itsdillon
changed the title
blitz generate in javascript projectsblitz generate in javascript projects
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: blitz-js/legacy-framework#462
What are the changes and their implications?
It turns out that babel transform was relying on a local babel config, and that caused issues. Added
configFile: flaseto transform options. Also prettier didn't run for generated code in JS projects because of an early return. This PR fixes that as well.I also tested the JS project -
blitz start/dev/buildas well as generating new models, and it seems to work fine. Hence this PR should close the blitz-js/legacy-framework#462 issue.Bug Checklist
Feature Checklist
canarybranch)